Moonbase/jumpstart-games-reduxed
1
0
Fork 0
forked from SoDOff-Project/sodoff
Code Issues 1 Pull Requests Projects 1 Activity

WoJS Rank Up Message #4

Merged
Moonbase merged 2 commits from rankup-message-wojs into master 2025-03-11 21:05:26 -07:00
Conversation 2 Commits 2 Files Changed 6 +38 -232
Moonbase commented 2025-03-11 18:03:17 -07:00
Owner
Copy Link

this is a WIP implementation of the rank up message in wojs (for level up cutscene)

WIP due to rank incorrect bug

  • add message to viking if level up is detected and wojs is game version
  • crappy fix for bug where viking rank isn't displayed correctly in some areas (TODO BEFORE MERGE - find better fix for this to keep sod and other game compatibility)
  • add empty url's for audio and image (otherwise cutscene would not play)
this is a WIP implementation of the rank up message in wojs (for level up cutscene) WIP due to rank incorrect bug - add message to viking if level up is detected and wojs is game version - crappy fix for bug where viking rank isn't displayed correctly in some areas (TODO BEFORE MERGE - find better fix for this to keep sod and other game compatibility) - add empty url's for audio and image (otherwise cutscene would not play)
Moonbase added 1 commit 2025-03-11 18:03:18 -07:00 
- add message to viking if level up is detected and wojs is game version
- crappy fix for bug where viking rank isn't displayed correctly in some areas
- add empty url's for audio and image (otherwise cutscene would not play)
Moonbase added 1 commit 2025-03-11 21:04:28 -07:00 
i just now got sod working locally
Moonbase commented 2025-03-11 21:05:12 -07:00
Author
Owner
Copy Link

older clients now show rank correctly while maintaining compatibility with sod, can probably merge now

older clients now show rank correctly while maintaining compatibility with sod, can probably merge now
Moonbase changed title from [WIP] WoJS Rank Up Message to WoJS Rank Up Message 2025-03-11 21:05:14 -07:00
Moonbase merged commit f739a44fcb into master 2025-03-11 21:05:26 -07:00
Moonbase deleted branch rankup-message-wojs 2025-03-11 21:05:26 -07:00
Moonbase commented 2025-03-12 16:09:07 -07:00
Author
Owner
Copy Link

immediately had to revert because the rank incorrect issue seems to also affect sod anyways, so this seems to be an underlying issue with sodoff

immediately had to revert because the rank incorrect issue seems to also affect sod anyways, so this seems to be an underlying issue with sodoff
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Moonbase
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Moonbase/jumpstart-games-reduxed#4
No description provided.
Delete Branch "rankup-message-wojs"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?