fix null exception in LoginParent

src/Controllers/Common/AuthenticationController.cs

@@ -48,8 +48,13 @@ public class AuthenticationController : Controller {
         } else {
             user = ctx.Users.FirstOrDefault(e => e.Username == data.UserName);
         }
+
+        if (user is null) {
+            return Ok(new ParentLoginInfo { Status = MembershipUserStatus.InvalidUserName });
+        }
+
         PasswordVerificationResult result = new PasswordHasher<object>().VerifyHashedPassword(null, user.Password, data.Password);
-        if (user is null || result == PasswordVerificationResult.Failed) {
+        if (result == PasswordVerificationResult.Failed) {
             return Ok(new ParentLoginInfo { Status = MembershipUserStatus.InvalidPassword });
         }
 

src/Dockerfile

@@ -1,5 +1,5 @@
 # Use the official .NET SDK image for building the application
-FROM mcr.microsoft.com/dotnet/sdk:6.0 AS build
+FROM mcr.microsoft.com/dotnet/sdk:9.0 AS build
 WORKDIR /src
 
 # Copy the source code
@@ -13,7 +13,7 @@ RUN mv src/mods /app && ln -s /app/mods src/
 RUN mv src/assets /app && ln -s /app/assets src/
 
 # Create clean run environment (without source and sdk)
-# FROM mcr.microsoft.com/dotnet/aspnet:6.0 AS base
+# FROM mcr.microsoft.com/dotnet/aspnet:9.0 AS base
 # WORKDIR /app
 # COPY --from=build /app .
 

src/Schema/AchievementReward.cs

@@ -5,7 +5,7 @@ namespace sodoff.Schema;
 [XmlRoot(ElementName = "AR", Namespace = "")]
 [Serializable]
 public class AchievementReward {
-    public AchievementReward() {}
+    public AchievementReward() { }
 
     public AchievementReward(AchievementReward other) {
         if (other.UserItem != null)
@@ -65,6 +65,6 @@ public class AchievementReward {
     public int CommonInventoryID;
 
     public AchievementReward Clone() {
-		return (AchievementReward) this.MemberwiseClone();
+        return (AchievementReward)this.MemberwiseClone();
     }
 }

src/Schema/BluePrint.cs

@@ -6,7 +6,7 @@ namespace sodoff.Schema;
 [XmlRoot(ElementName = "BP", Namespace = "", IsNullable = true)]
 [Serializable]
 public class BluePrint {
-    public BluePrint() {}
+    public BluePrint() { }
 
     public BluePrint(BluePrint other) {
         Deductibles = other.Deductibles.Select(d => new BluePrintDeductibleConfig(d)).ToList();

src/Schema/BluePrintSpecification.cs

@@ -3,7 +3,7 @@ using System.Xml.Serialization;
 namespace sodoff.Schema;
 
 public class BluePrintSpecification {
-    public BluePrintSpecification() {}
+    public BluePrintSpecification() { }
 
     public BluePrintSpecification(BluePrintSpecification other) {
         BluePrintSpecID = other.BluePrintSpecID;

src/Schema/CompletionAction.cs

@@ -4,7 +4,7 @@ namespace sodoff.Schema;
 
 [Serializable]
 public class CompletionAction {
-    public CompletionAction() {}
+    public CompletionAction() { }
 
     public CompletionAction(CompletionAction other) {
         Transition = other.Transition;

src/Schema/ItemAttribute.cs

@@ -5,7 +5,7 @@ namespace sodoff.Schema;
 [XmlRoot(ElementName = "AT", Namespace = "")]
 [Serializable]
 public class ItemAttribute {
-    public ItemAttribute() {}
+    public ItemAttribute() { }
 
     public ItemAttribute(ItemAttribute other) {
         Key = other.Key;

src/Schema/ItemAvailability.cs

@@ -5,7 +5,7 @@ namespace sodoff.Schema;
 [XmlRoot(ElementName = "Availability", Namespace = "")]
 [Serializable]
 public class ItemAvailability {
-    public ItemAvailability() {}
+    public ItemAvailability() { }
 
     public ItemAvailability(ItemAvailability other) {
         StartDate = other.StartDate;

src/Schema/ItemData.cs

@@ -4,7 +4,7 @@ namespace sodoff.Schema;
 
 [XmlRoot(ElementName = "I", Namespace = "", IsNullable = true)]
 public class ItemData {
-    public ItemData() {}
+    public ItemData() { }
 
     public ItemData(ItemData other) {
         ItemStates = other.ItemStates.Select(s => new ItemState(s)).ToList();

src/Schema/ItemDataCategory.cs

@@ -5,7 +5,7 @@ namespace sodoff.Schema;
 [XmlRoot(ElementName = "IC", Namespace = "")]
 [Serializable]
 public class ItemDataCategory {
-    public ItemDataCategory() {}
+    public ItemDataCategory() { }
 
     public ItemDataCategory(ItemDataCategory other) {
         CategoryId = other.CategoryId;

src/Schema/ItemDataRelationship.cs

@@ -5,7 +5,7 @@ namespace sodoff.Schema;
 [XmlRoot(ElementName = "IRE", Namespace = "")]
 [Serializable]
 public class ItemDataRelationship {
-    public ItemDataRelationship() {}
+    public ItemDataRelationship() { }
 
     public ItemDataRelationship(ItemDataRelationship other) {
         Type = other.Type;

src/Schema/ItemDataRollover.cs

@@ -5,7 +5,7 @@ namespace sodoff.Schema;
 [XmlRoot(ElementName = "IRO", Namespace = "")]
 [Serializable]
 public class ItemDataRollover {
-    public ItemDataRollover() {}
+    public ItemDataRollover() { }
 
     public ItemDataRollover(ItemDataRollover other) {
         DialogName = other.DialogName;

src/Schema/ItemDataTexture.cs

@@ -5,7 +5,7 @@ namespace sodoff.Schema;
 [XmlRoot(ElementName = "IT", Namespace = "")]
 [Serializable]
 public class ItemDataTexture {
-    public ItemDataTexture() {}
+    public ItemDataTexture() { }
 
     public ItemDataTexture(ItemDataTexture other) {
         TextureName = other.TextureName;

src/Schema/ItemPossibleStatsMap.cs

@@ -5,7 +5,7 @@ namespace sodoff.Schema;
 [XmlRoot(ElementName = "IPSM", Namespace = "", IsNullable = false)]
 [Serializable]
 public class ItemPossibleStatsMap {
-    public ItemPossibleStatsMap() {}
+    public ItemPossibleStatsMap() { }
 
     public ItemPossibleStatsMap(ItemPossibleStatsMap other) {
         ItemID = other.ItemID;

src/Schema/ItemSaleConfig.cs

@@ -5,7 +5,7 @@ namespace sodoff.Schema;
 [XmlRoot(ElementName = "ISC", Namespace = "", IsNullable = true)]
 [Serializable]
 public class ItemSaleConfig {
-    public ItemSaleConfig() {}
+    public ItemSaleConfig() { }
 
     public ItemSaleConfig(ItemSaleConfig other) {
         ItemID = other.ItemID;

src/Schema/ItemStat.cs

@@ -5,7 +5,7 @@ namespace sodoff.Schema;
 [XmlRoot(ElementName = "IS", Namespace = "")]
 [Serializable]
 public class ItemStat {
-    public ItemStat() {}
+    public ItemStat() { }
 
     public ItemStat(ItemStat other) {
         ItemStatID = other.ItemStatID;

src/Schema/ItemStateCriteria.cs

@@ -11,7 +11,7 @@ namespace sodoff.Schema;
 [XmlInclude(typeof(ItemStateCriteriaExpiry))]
 [Serializable]
 public class ItemStateCriteria {
-    public ItemStateCriteria() {}
+    public ItemStateCriteria() { }
 
     public ItemStateCriteria(ItemStateCriteria other) {
         Type = other.Type;

src/Schema/ItemStateRule.cs

@@ -5,7 +5,7 @@ namespace sodoff.Schema;
 [XmlRoot(ElementName = "ItemStateRule", Namespace = "")]
 [Serializable]
 public class ItemStateRule {
-    public ItemStateRule() {}
+    public ItemStateRule() { }
 
     public ItemStateRule(ItemStateRule other) {
         Criterias = other.Criterias.Select(c => new ItemStateCriteria(c)).ToList();

src/Schema/ItemStatsMap.cs

@@ -5,7 +5,7 @@ namespace sodoff.Schema;
 [XmlRoot(ElementName = "ISM", Namespace = "", IsNullable = false)]
 [Serializable]
 public class ItemStatsMap {
-    public ItemStatsMap() {}
+    public ItemStatsMap() { }
 
     public ItemStatsMap(ItemStatsMap other) {
         ItemID = other.ItemID;

src/Schema/Mission.cs

@@ -3,9 +3,9 @@
 namespace sodoff.Schema;
 
 [XmlRoot(ElementName = "Mission", Namespace = "")]
-[Serializable] // FIXME: Remove serializable once we have a different way of deep copying than BinaryFormatter
+[Serializable]
 public class Mission {
-    public Mission() {}
+    public Mission() { }
 
     public Mission(Mission other) {
         if (other == null) throw new ArgumentNullException(nameof(other));

src/Schema/MissionCriteria.cs

@@ -5,7 +5,7 @@ namespace sodoff.Schema;
 [XmlRoot(ElementName = "MissionCriteria", Namespace = "")]
 [Serializable]
 public class MissionCriteria {
-    public MissionCriteria() {}
+    public MissionCriteria() { }
 
     public MissionCriteria(MissionCriteria other) {
         Type = other.Type;

src/Schema/MissionRule.cs

@@ -5,7 +5,7 @@ namespace sodoff.Schema;
 [XmlRoot(ElementName = "MissionRule", Namespace = "")]
 [Serializable]
 public class MissionRule {
-    public MissionRule() {}
+    public MissionRule() { }
 
     public MissionRule(MissionRule other) {
         Prerequisites = other.Prerequisites.Select(p => new PrerequisiteItem(p)).ToList();

src/Schema/Pair.cs

@@ -5,7 +5,7 @@ namespace sodoff.Schema;
 [XmlRoot(ElementName = "Pair", Namespace = "")]
 [Serializable]
 public class Pair {
-    public Pair() {}
+    public Pair() { }
 
     public Pair(Pair other) {
         PairKey = other.PairKey;

src/Schema/PairData.cs

@@ -5,7 +5,7 @@ namespace sodoff.Schema;
 [XmlRoot(ElementName = "Pairs", Namespace = "", IsNullable = true)]
 [Serializable]
 public class PairData {
-    public PairData() {}
+    public PairData() { }
 
     public PairData(PairData other) {
         Pairs = other.Pairs.Select(p => new Pair(p)).ToArray();

src/Schema/PrerequisiteItem.cs

@@ -5,7 +5,7 @@ namespace sodoff.Schema;
 [XmlRoot(ElementName = "PrerequisiteItem", Namespace = "")]
 [Serializable]
 public class PrerequisiteItem {
-    public PrerequisiteItem() {}
+    public PrerequisiteItem() { }
 
     public PrerequisiteItem(PrerequisiteItem other) {
         Type = other.Type;

src/Schema/RuleItem.cs

@@ -5,7 +5,7 @@ namespace sodoff.Schema;
 [XmlRoot(ElementName = "RuleItem", Namespace = "")]
 [Serializable]
 public class RuleItem {
-    public RuleItem() {}
+    public RuleItem() { }
 
     public RuleItem(RuleItem other) {
         Type = other.Type;

src/Schema/Stat.cs

@@ -5,7 +5,7 @@ namespace sodoff.Schema;
 [XmlRoot(ElementName = "STAT", Namespace = "", IsNullable = false)]
 [Serializable]
 public class Stat {
-    public Stat() {}
+    public Stat() { }
 
     public Stat(Stat other) {
         ItemID = other.ItemID;

src/Schema/StatRangeMap.cs

@@ -5,7 +5,7 @@ namespace sodoff.Schema;
 [XmlRoot(ElementName = "SRM", Namespace = "", IsNullable = false)]
 [Serializable]
 public class StatRangeMap {
-    public StatRangeMap() {}
+    public StatRangeMap() { }
 
     public StatRangeMap(StatRangeMap other) {
         ItemStatsID = other.ItemStatsID;

src/Schema/Task.cs

@@ -8,7 +8,7 @@ namespace sodoff.Schema;
 [XmlRoot(ElementName = "Task", Namespace = "")]
 [Serializable]
 public class Task {
-    public Task() {}
+    public Task() { }
 
     public Task(Task other) {
         TaskID = other.TaskID;

src/Schema/UserItemData.cs

@@ -5,7 +5,7 @@ namespace sodoff.Schema;
 [XmlRoot(ElementName = "UserItem", Namespace = "")]
 [Serializable]
 public class UserItemData {
-    public UserItemData() {}
+    public UserItemData() { }
 
     public UserItemData(UserItemData other) {
         ItemID = other.ItemID;