fix upcoming missions in GetUserMissionState

* this is bugfix for upcoming missions issue in SoD 2.9 after 60cc00d
* also removed TODO because ProductGroupID is not related to mission.GroupID and ProductGroupID filtering is covered by gameVersion

src/Controllers/Common/ContentController.cs

@@ -1109,14 +1109,17 @@ public class ContentController : Controller {
             foreach (var m in filterV2.MissionPair)
                 if (m.MissionID != null)
                     result.Missions.Add(missionService.GetMissionWithProgress((int)m.MissionID, viking.Id, gameVersion));
-        // TODO: probably should also check for mission based on filterV2.ProductGroupID vs mission.GroupID
         } else {
             if (filterV2.GetCompletedMission ?? false) {
                 foreach (var mission in viking.MissionStates.Where(x => x.MissionStatus == MissionStatus.Completed))
                     result.Missions.Add(missionService.GetMissionWithProgress(mission.MissionId, viking.Id, gameVersion));
             } else {
-                foreach (var mission in viking.MissionStates.Where(x => x.MissionStatus != MissionStatus.Completed))
+                var missionStatesById = viking.MissionStates.Where(x => x.MissionStatus != MissionStatus.Completed).ToDictionary(ms => ms.MissionId);
-                    result.Missions.Add(missionService.GetMissionWithProgress(mission.MissionId, viking.Id, gameVersion));
+                HashSet<int> upcomingMissionIds = new(missionStore.GetUpcomingMissions(gameVersion));
+                var combinedMissionIds = new HashSet<int>(missionStatesById.Keys);
+                combinedMissionIds.UnionWith(upcomingMissionIds);
+                foreach (var missionId in combinedMissionIds)
+                    result.Missions.Add(missionService.GetMissionWithProgress(missionId, viking.Id, gameVersion));
             }
         }
 

src/sodoff.csproj

@@ -8,6 +8,8 @@
     <DefineConstants>USE_SQLITE;$(DefineConstants)</DefineConstants>
     <DefineConstants>USE_POSTGRESQL;$(DefineConstants)</DefineConstants>
     <DefineConstants>USE_MYSQL;$(DefineConstants)</DefineConstants>
+
+    <NoWarn>8600,8601,8602,8603,8604,8618,8625,8629</NoWarn>
   </PropertyGroup>
 
   <ItemGroup>