SoDOff-Project/sodoff
1
0
Fork 1
mirror of https://github.com/SoDOff-Project/sodoff.git synced 2025-10-11 08:18:49 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix null item corrupting profiles

Browse Source
This commit is contained in:
Spirtix 2023-07-31 13:18:53 +02:00
parent d7f3ad81bd
commit 2a76705c33
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/Controllers/Common/ContentController.cs
View File

@ -189,6 +189,7 @@ public class ContentController : Controller {
// Now that we know the request is valid, update the inventory // Now that we know the request is valid, update the inventory
foreach (var req in request) { foreach (var req in request) {
if (req.ItemID == 0) continue; // Do not save a null item
InventoryItem? item = viking.Inventory.InventoryItems.FirstOrDefault(e => e.ItemId == req.ItemID); InventoryItem? item = viking.Inventory.InventoryItems.FirstOrDefault(e => e.ItemId == req.ItemID);
if (item is null) { if (item is null) {
item = new InventoryItem { ItemId = (int)req.ItemID, Quantity = 0 }; item = new InventoryItem { ItemId = (int)req.ItemID, Quantity = 0 };
@ -198,7 +199,7 @@ public class ContentController : Controller {
if (req.Quantity > 1) if (req.Quantity > 1)
updateQuantity = req.Quantity; // Otherwise it expects the quantity from the request updateQuantity = req.Quantity; // Otherwise it expects the quantity from the request
item.Quantity += req.Quantity; item.Quantity += req.Quantity;
ctx.SaveChanges(); // We need to get an ID of a newly created item ctx.SaveChanges(); // We need to get the ID of the newly created item
if (req.Quantity > 0) if (req.Quantity > 0)
responseItems.Add(new CommonInventoryResponseItem { responseItems.Add(new CommonInventoryResponseItem {
CommonInventoryID = item.Id, CommonInventoryID = item.Id,
@ -228,6 +229,8 @@ public class ContentController : Controller {
[Produces("application/xml")] [Produces("application/xml")]
[Route("ItemStoreWebService.asmx/GetItem")] // NOTE: Should be in a separate controler, but it's inventory related, so I'll leave it here for now [Route("ItemStoreWebService.asmx/GetItem")] // NOTE: Should be in a separate controler, but it's inventory related, so I'll leave it here for now
public IActionResult GetItem([FromForm] int itemId) { public IActionResult GetItem([FromForm] int itemId) {
if (itemId == 0) // For a null item, return an empty item
return Ok(new ItemData());
return Ok(itemService.GetItem(itemId)); return Ok(itemService.GetItem(itemId));
} }