Moonbase/jumpstart-games-reduxed
1
0
Fork 0
forked from SoDOff-Project/sodoff
Code Issues 1 Pull Requests Projects 1 Activity

more friendly response for profile not found

Browse Source
This commit is contained in:
Robert Paciorek 2023-09-13 08:42:36 +00:00 committed by Spirtix
parent 31a985334d
commit e88a5db3bf
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/Controllers/Common/ProfileController.cs
View File

@ -23,8 +23,11 @@ public class ProfileController : Controller {
// NOTE: this is public info (for mmo) - no session check // NOTE: this is public info (for mmo) - no session check
Viking? viking = ctx.Vikings.FirstOrDefault(e => e.Id == userId); Viking? viking = ctx.Vikings.FirstOrDefault(e => e.Id == userId);
if (viking is null) if (viking is null) {
return Conflict("Viking not found"); return Ok(new UserProfileData());
// NOTE: do not return `Conflict("Viking not found")` due to client side error handling
// (not Ok response cause soft-lock client - can't close error message)
}
return Ok(GetProfileDataFromViking(viking)); return Ok(GetProfileDataFromViking(viking));
} }