From d1258b6082b0627ba7eb36e91029ff163790d0be Mon Sep 17 00:00:00 2001 From: Robert Paciorek Date: Fri, 12 Apr 2024 10:02:53 +0000 Subject: [PATCH] fixes for avoid network error in client - return 200 OK for /ContentWebService.asmx - return 404 (and log error) on connection error to asset provider server --- src/Controllers/Common/AnalyticsController.cs | 1 + src/Middleware/AssetMiddleware.cs | 5 +++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/Controllers/Common/AnalyticsController.cs b/src/Controllers/Common/AnalyticsController.cs index 740da72..7692f68 100644 --- a/src/Controllers/Common/AnalyticsController.cs +++ b/src/Controllers/Common/AnalyticsController.cs @@ -14,6 +14,7 @@ namespace sodoff.Controllers.Common } [Route("ping")] + [Route("ContentWebService.asmx")] // ping URL used by SoD public IActionResult Ping() { return Ok(); diff --git a/src/Middleware/AssetMiddleware.cs b/src/Middleware/AssetMiddleware.cs index 1a27280..c6e2b55 100644 --- a/src/Middleware/AssetMiddleware.cs +++ b/src/Middleware/AssetMiddleware.cs @@ -138,11 +138,12 @@ public class AssetMiddleware } } } - catch (Exception) { + catch (Exception err) { + Console.WriteLine($"{err}"); if (File.Exists(filePathTmp)) File.Delete(filePathTmp); if (!context.Response.HasStarted) - context.Response.StatusCode = 502; + context.Response.StatusCode = 404; } }