From 56c388b1d68fb717d5f8cfcfc96f24abbe7461c5 Mon Sep 17 00:00:00 2001 From: Robert Paciorek Date: Tue, 6 Feb 2024 20:20:35 +0000 Subject: [PATCH] fix internal server error on 2.9 quests also fix error on invalid SetAvatar call --- src/Controllers/Common/ContentController.cs | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/Controllers/Common/ContentController.cs b/src/Controllers/Common/ContentController.cs index f19af1e..5dabbcf 100644 --- a/src/Controllers/Common/ContentController.cs +++ b/src/Controllers/Common/ContentController.cs @@ -194,6 +194,12 @@ public class ContentController : Controller { CommonInventoryRequest[] request = XmlUtil.DeserializeXml(commonInventoryRequestXml); List responseItems = new(); + if (request is null) { + return Ok(new CommonInventoryResponse { + Success = false + }); + } + // SetCommonInventory can remove any number of items from the inventory, this checks if it's possible foreach (var req in request) { if (req.Quantity >= 0) continue; @@ -320,6 +326,7 @@ public class ContentController : Controller { // do not allow override newer version avatar data by older version return Ok(new SetAvatarResult { Success = false, + StatusCode = AvatarValidationResult.Error }); } }