From 3ddc1e205c595b994df202c7b10eac855615c9da Mon Sep 17 00:00:00 2001 From: Spirtix Date: Wed, 18 Oct 2023 08:21:37 +0200 Subject: [PATCH] fix stable quest reward with invalid pet ID --- src/Services/AchievementService.cs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/Services/AchievementService.cs b/src/Services/AchievementService.cs index ecc8c36..dcbbbf8 100644 --- a/src/Services/AchievementService.cs +++ b/src/Services/AchievementService.cs @@ -110,10 +110,11 @@ namespace sodoff.Services { public AchievementReward[] ApplyAchievementRewards(Viking viking, AchievementReward[] rewards, Guid[]? dragonsIDs = null) { if (rewards is null) return null; - List grantedRewards = new List(); foreach (var reward in rewards) { if (dragonsIDs != null && reward.PointTypeID == AchievementPointTypes.DragonXP) { + if (dragonsIDs.Length == 0) + continue; double amountDouble = (reward.Amount ?? 0)/dragonsIDs.Length; int amount = (int)Math.Ceiling(amountDouble); foreach (Guid dragonID in dragonsIDs) {